server
server copied to clipboard
[PS-1279] feat: add equivilent domains for philips
Type of change
- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other
Objective
Makes all Philips domains equivalent, they all redirect to philips.com for authentication.
I'm not 100% sure if this is an appropriate case for it, so please just let me know if not.
I was caught out since I prefer to add passwords after account creation rather than let Bitwarden do it automatically, and I didn't notice I was redirected from .co.uk to .com for authentication. Because the password was added after the account was created, so after I was redirected back to .co.uk, the browser extension used that domain. Makes sense, but also a bit of a pain.
Code changes
- src/Core/Utilities/StaticStore.cs: Adds Philips domains, parsed out from here, sorted, and with duplicates removed. I tried a couple of them and all domains I tested redirect to philips.com for authentication.
- src/Core/Enums/GlobalEquivalentDomainsType.cs: Adds Philips entry to enum.
Before you submit
- [x] I have checked for formatting errors (
dotnet tool run dotnet-format --check) (required) - N/A If making database changes - I have also updated Entity Framework queries and/or migrations
- N/A I have added unit tests where it makes sense to do so (encouraged but not required)
- N/A This change requires a documentation update (notify the documentation team)
- N/A This change has particular deployment requirements (notify the DevOps team)
Hi @SethFalco, thank you for contributing! This will be tracked in our internal community PR board for review, and a team member will get back to you on your PR. Much appreciated!
@SethFalco thank you for your contribution. For security reasons, we cannot accept community contributions updating the global equivalent domains. If you need these domains to be equivalent, please set this up for your personal use. Thank you.