sdk
sdk copied to clipboard
[SM-1266] Review PHP docs
đī¸ Tracking
https://bitwarden.atlassian.net/browse/SM-1266
đ Objective
Review PHP language docs. Fixed some of the typos too that prevented the example to work correctly.
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 6537ff0d-2e6f-489b-803d-5cf1c51640ac
No New Or Fixed Issues Found
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.98%. Comparing base (
7ee604f) to head (4a973df). Report is 27 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 57.98% 57.98%
=======================================
Files 197 197
Lines 13651 13651
=======================================
Hits 7916 7916
Misses 5735 5735
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Superseded by #1032 and #1036