sdk icon indicating copy to clipboard operation
sdk copied to clipboard

chore: update sdk-internal

Open tangowithfoxtrot opened this issue 1 month ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/SM-1738

📔 Objective

Update sdk-internal crates. This, unfortunately required some pretty heavy, less-than-ideal changes, which I've added comments for throughout the PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

tangowithfoxtrot avatar Nov 05 '25 15:11 tangowithfoxtrot

Logo Checkmarx One – Scan Summary & Details – e490c04e-b6bc-448c-b341-1623f9cd8123

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Nov 05 '25 16:11 github-actions[bot]

Codecov Report

:x: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 15.34%. Comparing base (abda0ca) to head (a31e48c). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bws/src/command/project.rs 0.00% 9 Missing :warning:
crates/bws/src/command/secret.rs 0.00% 9 Missing :warning:
crates/bws/src/command/run.rs 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
- Coverage   15.42%   15.34%   -0.08%     
==========================================
  Files          21       21              
  Lines        1193     1199       +6     
==========================================
  Hits          184      184              
- Misses       1009     1015       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 05 '25 16:11 codecov[bot]

Setting this back to a draft until https://github.com/bitwarden/sdk-internal/pull/562 is merged to fix the WASM builds.

tangowithfoxtrot avatar Nov 18 '25 13:11 tangowithfoxtrot