sdk icon indicating copy to clipboard operation
sdk copied to clipboard

fix: math lib is not linked in linux

Open fawaf opened this issue 1 year ago â€ĸ 6 comments

From https://github.com/bitwarden/sdk-go/pull/2/files

Thanks to @mattscamp

đŸŽŸī¸ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

fawaf avatar Oct 08 '24 08:10 fawaf

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 08 '24 08:10 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 08 '24 08:10 CLAassistant

@mandreko-bitwarden @coroiu @michalchecinski poke

fawaf avatar Feb 07 '25 10:02 fawaf

Logo Checkmarx One – Scan Summary & Details – 20009975-266d-4805-88de-8f71ab426d28

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Feb 07 '25 14:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 7.32%. Comparing base (66967f0) to head (35822c6). Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1120   +/-   ##
=====================================
  Coverage   7.32%   7.32%           
=====================================
  Files         20      20           
  Lines       1378    1378           
=====================================
  Hits         101     101           
  Misses      1277    1277           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 07 '25 14:02 codecov[bot]