Add licenses to SM languages
đ Objective
Add license files to SM language wrappers
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.31%. Comparing base (
0ae6d73) to head (f2ec10c). Report is 29 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 193 193
Lines 13553 13553
=======================================
Hits 7904 7904
Misses 5649 5649
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â c1d67383-b5b7-4e4b-953f-e4943d238997
No New Or Fixed Issues Found
Is this still valid with the public statement that this should be GPL3, or am I misunderstanding? Looks like it was split out into https://github.com/bitwarden/sdk-internal ?
hi! it would be great to have this merged - possible?