[PM-11924] Add ssh-key item type
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-11924
Server PR: https://bitwarden.atlassian.net/browse/PM-10394
đ Objective
Add a new item type for ssh-keys.
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â cbe63d41-a2c4-4902-8377-9f7ec59a7ba9
No New Or Fixed Issues Found
Codecov Report
Attention: Patch coverage is 85.54913% with 25 lines in your changes missing coverage. Please review.
Project coverage is 58.60%. Comparing base (
be75311) to head (b835c2f). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 58.27% 58.60% +0.32%
==========================================
Files 197 198 +1
Lines 13614 13782 +168
==========================================
+ Hits 7934 8077 +143
- Misses 5680 5705 +25
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems the linting and ruby build failures are unrelated and also happening on other PRs.
Merged in the latest main which should fix most of the workflows.