sdk icon indicating copy to clipboard operation
sdk copied to clipboard

[PM-11924] Add ssh-key item type

Open quexten opened this issue 1 year ago â€ĸ 4 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-11924

Server PR: https://bitwarden.atlassian.net/browse/PM-10394

📔 Objective

Add a new item type for ssh-keys.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

quexten avatar Sep 11 '24 09:09 quexten

Logo Checkmarx One – Scan Summary & Details – cbe63d41-a2c4-4902-8377-9f7ec59a7ba9

No New Or Fixed Issues Found

github-actions[bot] avatar Sep 11 '24 09:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 85.54913% with 25 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (be75311) to head (b835c2f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/ssh_key.rs 0.00% 15 Missing :warning:
crates/bitwarden-exporters/src/models.rs 14.28% 6 Missing :warning:
crates/bitwarden-vault/src/cipher/cipher.rs 94.64% 3 Missing :warning:
crates/bitwarden-exporters/src/lib.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
+ Coverage   58.27%   58.60%   +0.32%     
==========================================
  Files         197      198       +1     
  Lines       13614    13782     +168     
==========================================
+ Hits         7934     8077     +143     
- Misses       5680     5705      +25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 11 '24 09:09 codecov[bot]

Seems the linting and ruby build failures are unrelated and also happening on other PRs.

quexten avatar Oct 01 '24 14:10 quexten

Merged in the latest main which should fix most of the workflows.

Hinton avatar Oct 08 '24 09:10 Hinton