passwordless-server
passwordless-server copied to clipboard
PAS-558 | Refactor application creation & avoid enumeration
trafficstars
Ticket
- Closes PAS-558
Description
Shape
- No more duplication checks for application identifier allow us to drop a lot of business logic.
- The API is responsible for returning the created application's id, so the admin console can store the application identifier together with the public keys and the secret keys for communication.
Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
- __
I did the following to ensure that my changes do not introduce security vulnerabilities:
- __
Codecov Report
Attention: Patch coverage is 16.30435% with 77 lines in your changes missing coverage. Please review.
Project coverage is 34.88%. Comparing base (
c1bb7c5) to head (69b176b).
Additional details and impacted files
@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 34.88% 34.88% -0.01%
==========================================
Files 566 567 +1
Lines 30995 30961 -34
Branches 933 931 -2
==========================================
- Hits 10814 10802 -12
+ Misses 20038 20017 -21
+ Partials 143 142 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't think this is an initiative we want to merge, will need to review at a later date. Please hold this.