passwordless-server icon indicating copy to clipboard operation
passwordless-server copied to clipboard

Clean up accounts with unconfirmed users

Open jrmccannon opened this issue 10 months ago • 1 comments

Ticket

Description

We've noticed a large influx of accounts being created and then never logging in to create an account. This will help identify those accounts and remove them after 30 days of no activity.

Shape

This adds setting EmailConfirmed for the user when they sign into passwordless adminconsole.

This also creates a background job that will clean up

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • I can successfully log in and EmailConfirmed is set successfully.

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • N/A

jrmccannon avatar Apr 18 '24 15:04 jrmccannon

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 34.09%. Comparing base (07ab18d) to head (7939188). Report is 52 commits behind head on main.

Files Patch % Lines
src/AdminConsole/Services/DataService.cs 0.00% 19 Missing :warning:
...ices/UnconfirmedAccountCleanUpBackgroundService.cs 0.00% 11 Missing :warning:
...sole/Services/MagicLinks/MagicLinkSignInManager.cs 0.00% 4 Missing :warning:
src/AdminConsole/Program.cs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   34.13%   34.09%   -0.04%     
==========================================
  Files         534      535       +1     
  Lines       27541    27572      +31     
  Branches      806      807       +1     
==========================================
  Hits         9400     9400              
- Misses      18010    18041      +31     
  Partials      131      131              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 18 '24 15:04 codecov[bot]