passwordless-server
passwordless-server copied to clipboard
Upgrade Stripe SDK
Description
Upgrades the Stripe SDK
Shape
We would have to monitor a production deployment, and upgrade the Stripe API version in the Stripe dashboard the exact moment the load balancer swaps the deployment slots.
Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
- __
I did the following to ensure that my changes do not introduce security vulnerabilities:
- __
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 32.38%. Comparing base (
b948250
) to head (56f5a0b
). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 32.38% 32.38%
=======================================
Files 518 518
Lines 26530 26530
Branches 849 849
=======================================
Hits 8591 8591
Misses 17821 17821
Partials 118 118
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@abergs If you merge it now we get plenty of time to test.
@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?
@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?
Yes. Setup the Stripe CLI and add a local listener. Then upgrade the Stripe SDK to verify. It will start throwing exceptions and return a 500.
We are only 2 major versions behind I think.