passwordless-server icon indicating copy to clipboard operation
passwordless-server copied to clipboard

Upgrade Stripe SDK

Open jonashendrickx opened this issue 10 months ago • 4 comments

Description

Upgrades the Stripe SDK

Shape

We would have to monitor a production deployment, and upgrade the Stripe API version in the Stripe dashboard the exact moment the load balancer swaps the deployment slots.

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

jonashendrickx avatar Apr 03 '24 09:04 jonashendrickx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.38%. Comparing base (b948250) to head (56f5a0b). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   32.38%   32.38%           
=======================================
  Files         518      518           
  Lines       26530    26530           
  Branches      849      849           
=======================================
  Hits         8591     8591           
  Misses      17821    17821           
  Partials      118      118           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 09:04 codecov[bot]

@abergs If you merge it now we get plenty of time to test.

jonashendrickx avatar Apr 05 '24 15:04 jonashendrickx

@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?

abergs avatar Apr 22 '24 15:04 abergs

@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?

Yes. Setup the Stripe CLI and add a local listener. Then upgrade the Stripe SDK to verify. It will start throwing exceptions and return a 500.

We are only 2 major versions behind I think.

jonashendrickx avatar Apr 24 '24 19:04 jonashendrickx