passwordless-server icon indicating copy to clipboard operation
passwordless-server copied to clipboard

Step up v2

Open jrmccannon opened this issue 10 months ago • 3 comments

Ticket

Description

This is the v2 of the step up API (really just adding Purpose to sign in). This also adds the authentication configuration endpoints to allow for admin console (or an API user) to set, get and create new step up purposes.

Shape

  • Adds purpose to SignInToken
  • Adds purpose to SignInVerifyDTO
  • Adds two default purposes of SignIn and StepUp
  • Adds new table AuthenticationConfiguration
  • Adds new AdminConsole Settings page.

Screenshots

Addition to Settings.cshtml image

Edit image

Create image

Delete image

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • validated existing sign in worked
  • validated new step up flow works
  • validated magic links worked
  • validated new admin console settings worked

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • validated you could not change tenant from blazor pages
  • ran existing integration tests to validate nothing broke

jrmccannon avatar Apr 01 '24 21:04 jrmccannon

Codecov Report

Attention: Patch coverage is 55.60027% with 662 lines in your changes missing coverage. Please review.

Project coverage is 34.11%. Comparing base (2fbab91) to head (872af36).

Files Patch % Lines
...6151601_AddAuthenticationConfiguration.Designer.cs 0.00% 449 Missing :warning:
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 40 Missing :warning:
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 40 Missing :warning:
...ttingsComponents/AuthenticationConfiguration.razor 0.00% 37 Missing :warning:
...e/20240416151601_AddAuthenticationConfiguration.cs 0.00% 22 Missing :warning:
...onfiguration/EditAuthenticationConfiguration.razor 0.00% 17 Missing :warning:
.../AdminConsole/Services/ScopedPasswordlessClient.cs 0.00% 12 Missing :warning:
...onfiguration/AuthenticationConfigurationForm.razor 0.00% 11 Missing :warning:
...figuration/AuthenticationConfigurationFormModel.cs 0.00% 10 Missing :warning:
...Configuration/NewAuthenticationConfiguration.razor 0.00% 9 Missing :warning:
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   33.00%   34.11%   +1.11%     
==========================================
  Files         514      536      +22     
  Lines       26131    27552    +1421     
  Branches      774      807      +33     
==========================================
+ Hits         8625     9400     +775     
- Misses      17378    18021     +643     
- Partials      128      131       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 01 '24 21:04 codecov[bot]

fyi: I noticed there is a merge conflict

abergs avatar Apr 23 '24 09:04 abergs

fyi: I noticed there is a merge conflict

Fixed 👍

jrmccannon avatar Apr 23 '24 12:04 jrmccannon