passwordless-server
passwordless-server copied to clipboard
Add missing AppFeature records
Ticket
No ticket.
Description
With the replacement of magic links in Admin Console with the API, it is relying on the AppFeature record to exist and for the monthly quota to be set. With it not set, AdminConsole can't send magic links.
Shape
- Added the max quota to the intiialize steps for AdminConsole.
- Also added a migration that will add an AppFeature record with some default values to every app that currently doesn't have an AppFeature record. This would be every application created before AppFeatures went live (June-August time frame).
Screenshots
N/A
Checklist
I did the following to ensure that my changes were tested thoroughly:
- Ran the script against my local database to make sure it executed and only updated the records it should have
I did the following to ensure that my changes do not introduce security vulnerabilities:
- N/A
Codecov Report
Attention: Patch coverage is 50.05834%
with 428 lines
in your changes missing coverage. Please review.
Project coverage is 32.94%. Comparing base (
83019a2
) to head (2404ea5
). Report is 142 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 32.38% 32.94% +0.55%
==========================================
Files 518 522 +4
Lines 26533 27390 +857
Branches 845 845
==========================================
+ Hits 8594 9023 +429
- Misses 17821 18249 +428
Partials 118 118
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks mostly good, see comment