passwordless-dotnet icon indicating copy to clipboard operation
passwordless-dotnet copied to clipboard

Improve service registration

Open Tyrrrz opened this issue 1 year ago • 0 comments

JIRA item: https://bitwarden.atlassian.net/browse/PAS-206


Based on the items raised in the "general feedback" meeting with me and @abergs.

Suggestion 1: rename AddPasswordlessSdk() to AddPassworless(). The Identity integration should either provide its own overloads with the same name (ideal) or have a separate method, like AddPasswordlessIdentity() (less ideal).

Suggestion 2: AddPasswordlessSdk() should either be callable without arguments (in which case the ApiKey/ApiSecret are resolved from conventional environment variables), or the options => ... overload should throw an exception when those two values aren't provided.

Tyrrrz avatar Sep 20 '23 17:09 Tyrrrz