mobile icon indicating copy to clipboard operation
mobile copied to clipboard

Published 20 hours ago • verified publisher icon bitwarden

[PM-8372] Generate higher minimum number/special character values

Open C4SH4FC7olONDtN4WpREWPJi7p3TIbQtgE4b4sl opened this issue 1 year ago • 1 comments

Type of change

  • [x] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ ] Other

Objective

Fixes https://github.com/bitwarden/mobile-maui/issues/3259

Code changes

Context: see desktop blob and mobile blob for comparison.

  • src/Core/Pages/Generator/GeneratorPage.xaml: Change max value of MinNumber and MinSpecial (5 -> 9)

I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.

C4SH4FC7olONDtN4WpREWPJi7p3TIbQtgE4b4sl avatar May 24 '24 05:05 C4SH4FC7olONDtN4WpREWPJi7p3TIbQtgE4b4sl

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-8372

thBGQIXdam4xJyYT1NoeyWaaY2V32AT4G9C4ayo avatar May 24 '24 05:05 thBGQIXdam4xJyYT1NoeyWaaY2V32AT4G9C4ayo

This repo has been archived. If you would like to contribute code to the new native mobile apps, visit the iOS / Android repo.

closebot-bw avatar May 06 '25 20:05 closebot-bw