mobile icon indicating copy to clipboard operation
mobile copied to clipboard

[PM-5760] Add autofill support for Spin Browser

Open theRealPadster opened this issue 1 year ago • 2 comments

Type of change

  • [ ] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [x] Other

Objective

Bitwarden autofill doesn't work in Spin Browser. More details in this issue: https://github.com/bitwarden/mobile/issues/2848. Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality. Website: https://spinsafebrowser.com Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser

Code changes

  • AutofillHelpers.cs: Added "com.nationaledtech.spinbrowser",
  • AccessibilityHelpers.cs: Added new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),
  • autofillservice.xml Added <compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>
  • Some trailing whitespace was also auto-removed from AutofillHelpers.cs and AccessibilityHelpers.cs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

theRealPadster avatar Jan 17 '24 22:01 theRealPadster

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 17 '24 22:01 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-5760

bitwarden-bot avatar Jan 17 '24 22:01 bitwarden-bot

CLA assistant check
All committers have signed the CLA.

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-5760