mobile icon indicating copy to clipboard operation
mobile copied to clipboard

[PM-4760] Admin Recovery Permissions prompted to set MP.

Open andrebispo5 opened this issue 1 year ago • 1 comments

Type of change

  • [X] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ ] Other

Objective

If elevating user’s role to Custom role with the “Manage Account Recovery” permission, the user needs to be prompted to set a master password. This check is made on Sync.

Code changes

Add force password reset check on sync complete. This check also runs on TabsPage OnAppearing, we will leverage existing broadcast subscription to "synccomplete" to also check for password reset.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

andrebispo5 avatar Dec 21 '23 14:12 andrebispo5

Logo Checkmarx One – Scan Summary & Detailsb0efebd5-3b8e-428b-bd4b-1aa66eff42eb

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Password_In_Comment /src/Core/Enums/PolicyType.cs: 13 Attack Vector

bitwarden-bot avatar Feb 19 '24 19:02 bitwarden-bot

Logo Checkmarx One – Scan Summary & Detailsb0efebd5-3b8e-428b-bd4b-1aa66eff42eb

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Password_In_Comment /src/Core/Enums/PolicyType.cs: 13 Attack Vector