Screen Flashing on Back Navigation since 2023.7.1

[quexten]

Steps To Reproduce

1. Go to "My vault"
2. Click on a Login
3. Navigate back

Expected Result

The screen should not flash on back navigation.

Actual Result

The screen flashes.

Screenshots or Videos

Screencast from 2023-08-29 11-56-50.webm

Additional Context

I triaged it down to the PR https://github.com/bitwarden/mobile/pull/2604. As a side-effect of the PR, or more specifically, this part: https://github.com/bitwarden/mobile/blob/e9bfeb2a9e8463ebd1544386acdd0ffd4c20bd7c/src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs#L387-L392 the screen begins to flash on back navigation. Removing the Device.BeginInvokeOnMainThread fixes the bug, but also defeats the point of the PR.

Operating System

Android

Operating System Version

Android 13

Device

Google Emulator, Mi9T Pro

Build Version

2023.7.1

Beta

• [ ] Using a pre-release version of the application.

[Krychaz]

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

[quexten]

@Krychaz do note that while I was technically not using a pre-release version, the latest google-play release is still on 2023.07 which does not have the bug. On 2023.7.1 and 2023.8.0 (which are marked as releases here on GitHub, but are not yet in google-play) I was able to reproduce the bug consistently on 2 different Android phones and the Android emulator. It seems the "flashing" (i.e the list briefly disappearing) is shorter on faster devices (but never completely gone).

Hope that helps to reproduce it.

[quexten]

Just tested on iOS on an iPad Pro 2020. On 2023.7.0 the bug does not happen. On the current version from the app store - 2023.8.0 it does happen, although it is much less noticeable. On an older android phone the "flashing" takes around a second, on the ipad it was barely visible:

https://github.com/bitwarden/mobile/assets/11866552/176d30a3-539a-4c76-b072-abceeb79e441

[Doorstop2]

I'm on the pixel 7 and this is happening on the latest version

[BabyOilJohnson]

Same here on Samsung A30(A11) v2023.8.0

https://github.com/bitwarden/mobile/assets/101601874/959ef45b-303a-4efa-973e-ef9bab6ef5fa

[vinnyperella]

This happens every time I open the app from the PIN unlock screen. It started occurring after the version 2023.8.0 update I was hoping it would be fixed with 2023.9.0 but I'm on 2023.9.1 and it is still an issue. I also just tested what the commenter showed above and it happens for me too going to any tab and then back to vault causes the flicker.

I'm using a Pixel XL (marlin) LineageOS 18.1+MicroG (Android 11).

[sarvesheb]

Issue still exists on v2023.12.0

[vinnyperella]

I believe this is now fixed I'm on version 2024.2.1 and I'm not seeing it anymore.

[quexten]

Still happening on iOS, even if less noticeable due to being faster on the device. However, given the native re-write of the apps, I also don't believe this is worth further investigating.