mobile
mobile copied to clipboard
[PM-3041] Add the possibility to require master password with biometrics on app reset
Type of change
- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
This PR addresses issue #2032, which is the possibility of setting if the app should ask for a master password with biometrics authentication on restart.
Code changes
- LockPageViewModel.cs: The addition of a condition to determine if the master password should be used instead
- SettingsPageViewModel.cs: Some refactoring to enable code reuse, and the code allowing to show the popup just after biometrics set up to ask if the master password should be required after the app reset
- AppResources.Designer.cs: Removal of
Pinprefix from the translation key - AppResources.resx: Removal of
Pinprefix from the translation key - IStateService.cs: The getter and setter methods declaration for the new option
- Constants.cs: The new option key's constant
- src/Core/Services/StateService.cs: The getter and setter methods implementation for the new option
Screenshots
Before you submit
- Please check for formatting errors (
dotnet format --verify-no-changes) (required) - Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-3041
Checkmarx One – Scan Summary & Details – 9833018c-5b7d-452d-bb01-48d67176c2fc
No New Or Fixed Issues Found
Hi, would something be done with this PR? I'd love to see this feature deployed as I've been waiting for it for months until I came across #2032
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-3041
Checkmarx One – Scan Summary & Details – 9833018c-5b7d-452d-bb01-48d67176c2fc
No New Or Fixed Issues Found
Hi, would something be done with this PR? I'd love to see this feature deployed as I've been waiting for it for months until I came across #2032