mobile icon indicating copy to clipboard operation
mobile copied to clipboard

PM-171 remove confirmation alert for restore item click in trash

Open Jingo88 opened this issue 1 year ago • 1 comments

Type of change

  • [ ] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ X ] Other

Objective

Removing the confirmation alert for restoring an item from Trash

Confirmation alerts should only be used as warnings if something is being deleted or for irreversible actions. Restoring an item does not fall under this definition.

Code changes

Removed confirmation alert lines for restore inside src/App/Pages/Vault/CipherDetailsPageViewModel.cs

Screenshots

https://github.com/bitwarden/mobile/assets/8302660/0e7a738f-4dcd-446c-b9f2-3dc32a65cdfe

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Jingo88 avatar Jul 12 '23 17:07 Jingo88

Logo Checkmarx One – Scan Summary & Details3ee29032-3f83-4bd8-b7c1-b58cb1862eed

No New Or Fixed Issues Found

bitwarden-bot avatar Jul 12 '23 17:07 bitwarden-bot

Logo Checkmarx One – Scan Summary & Details3ee29032-3f83-4bd8-b7c1-b58cb1862eed

No New Or Fixed Issues Found