mobile
mobile copied to clipboard
bitwarden
[PM-2313] Allow empty passphrase separator
Type of change
- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Closes #2525 Allow empty passphrase word separator in passphrase generator
Code changes
- PasswordGenerationService.cs: Removed the check for an empty wordSeparator where currently, it is defaulted to a space. Now, the wordSeparator will remain as the empty string.
Before you submit
- Please check for formatting errors (
dotnet format --verify-no-changes) (required) - Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-2313
Checkmarx One – Scan Summary & Details – a7c93648-f533-4b7f-a8e5-034334829308
No New Or Fixed Issues Found
Will not implement - this has been implemented in the upcoming native apps, so this particular PR is no longer needed. Thank you for your contribution @joseph082 !
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-2313
Checkmarx One – Scan Summary & Details – a7c93648-f533-4b7f-a8e5-034334829308
No New Or Fixed Issues Found
Will not implement - this has been implemented in the upcoming native apps, so this particular PR is no longer needed. Thank you for your contribution @joseph082 !