mobile
mobile copied to clipboard
Add refresh ability in autofill
Type of change
- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Closes #1710
This PR introduces the ability to pull to refresh in the autofill window like in the default app.
~~Since I am not able to run it in iOS, I didn't try it there... We probably still need to do some iOS specific stuff here... Any help is appreciated to try test it out there. I tried out #1939 but unfortunately don't have an Apple Developer account.~~ Works on iOS too.
cc @danstooamerican
Code changes
- AutofillCiphersPageViewModel.cs: Add
RefreshAsync() - AutofillCiphersPage.xaml Add
RefreshView - LoginListViewController.cs Add
RefreshControl_ActivatedAsync() - LoginListViewController.designer.cs Add
RefreshControl_ActivatedAsync - iOS.Autofill/MainInterface.storyboard Add
refreshControl - iOS.Core/Views Add
RefreshAsync()
Screenshots
iOS
https://user-images.githubusercontent.com/29506042/224867225-fa3adfc1-3f42-4085-a30d-f90e3d98fd59.mov
Android
https://user-images.githubusercontent.com/29506042/224867273-dd5dd4cc-12a6-44f8-9702-06de13def790.mov
Before you submit
- Please check for formatting errors (
dotnet format --verify-no-changes) (required) - Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
Hi @pavelzw I'm very intrested in this feature. Would it be possible to resolve the conflicts and merge the PR? Thanks in advance
I don't have merging rights here. If the maintainers are open for this change, I could try to fix the merge conflicts.
Thanks pavelzw
Hi @fedemkr I noticed that you have been recently reviewing and merging several PR on both ios and android clients. Do you mind having a look on this one please? I do beleive that this is an important feature as I'm personally very annoyed by the fact that autofill window is not sync.
Thanks in advance
Hi @pavelzw I'm very intrested in this feature. Would it be possible to resolve the conflicts and merge the PR? Thanks in advance
I don't have merging rights here. If the maintainers are open for this change, I could try to fix the merge conflicts.
Thanks pavelzw
Hi @fedemkr I noticed that you have been recently reviewing and merging several PR on both ios and android clients. Do you mind having a look on this one please? I do beleive that this is an important feature as I'm personally very annoyed by the fact that autofill window is not sync.
Thanks in advance
https://github.com/bitwarden/android/pull/2406
@fedemkr can we push this?