mobile
mobile copied to clipboard
[PS-1352] Fix ignore diacritics in search
This change updates the search function to ignore diacritical marks in search results. Marks are stripped from both the search input and results.
Type of change
- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Fixes #2008
Search results should match on base characters, ignoring any accents or other glyphs applied to the search term or the stored data.
Code changes
/src/Core/Utilities/StringExtensions.cs
- Added new file to contain String extension to normalize strings by removing diacritics.
/src/Core/Services/SerachService.cs
- Applied String extension to search term, item name and item subtitle.
Before you submit
- [X] I have checked for formatting errors (
dotnet tool run dotnet-format --check
) (required) - [ ] I have added unit tests where it makes sense to do so (encouraged but not required)
- [ ] This change requires a documentation update (notify the documentation team)
- [ ] This change has particular deployment requirements (notify the DevOps team)
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1352
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1352
@noncenz thank you for your contribution. Your work is good to go. I've decided to just clean up the dev logging and add a validation. This will be included in a future mobile release.