Accessibility: Boolean custom field icon lacks a text alternative

[patrickhlauke]

Steps To Reproduce

1. Use a screen reader (VoiceOver on iOS/Talkback on Android)
2. Go to an entry with a custom boolean field
3. Navigate to the custom boolean field

Expected Result

A screen reader show announce the boolean as either checked/unchecked, on/off, true/false, or similar

Actual Result

The custom character/icon is passed to screen readers as the only value. As this is a custom character, it's not announced at all - VoiceOver / Talkback are silent when reaching the character.

Screenshots or Videos

iOS/VoiceOver screenshot - once focus is on the custom checked checkbox icon, note the voice output (bottom of the screen) is just showing the unrecognised custom character. Nothing is announced.

---

Android/Talkback screenshot - once focus is on the custom checked checkbox icon, note the voice output (bottom of the screen) is just showing the unrecognised custom character. Nothing is announced.

Additional Context

Note that in the extension, and in the desktop app, the boolean checkbox is announced as true or false.

Example using desktop app and NVDA/Windows

Example using chrome extension and NVDA/Windows

This is done with a visually-hidden, but exposed to AT, <span> element that contains the actual value of the field

Operating System

Android, iOS

Operating System Version

Latest

Device

iPhone SE (2020), Motorola moto g8

Build Version

2022.6.0 (1859) iOS / 2022.6.1 (4795) Android

Beta

• [ ] Using a pre-release version of the application.

[AE542]

Hi there, I'm thinking that just adding an accessibility hint to this field would allow it to read back if the box is checked or unchecked in VoiceOver. I'd like to try and tackle this, but I'd like to ask, where exactly is swift file with the custom field icon?

Thanks for your time.

[cwickes]

From what I can tell, this is no longer a problem on iOS. Can we close this issue?

[patrickhlauke]

From what I can tell, this is no longer a problem on iOS. Can we close this issue?

still the exact same problem on iOS with latest version (2023.3.2 (3195))

[TomerPacific]

@patrickhlauke - Do you need assistance with this issue?

[patrickhlauke]

well if somebody wants to submit a fix (essentially taking the same approach as the website/extension), sure. have at it. i've scaled back my contributions here a bit since things seemed to slow to a crawl at one point in terms of reviewing and merging...

[TomerPacific]

@patrickhlauke - Thanks for your reply. Who is the person I should talk to about this?

[djsmith85]

@patrickhlauke I'm really sorry for your poor experience with that specific PR you are referring to. Trying to learn from these things to create a better experience for any contributor.

@TomerPacific: As for guidance on getting started, please have a look at Bitwarden's Contributing Guidelines. This should give you everything you need to get your environment set-up and further guidance around contributing in general.

Kind regards, Daniel

[patrickhlauke]

@djsmith85 sorry, was clearly in a bit of a mood last night when i commented above. but yes more constructively, a bit more communication on some of the hanging PRs (where possible/appropriate) would help with just letting external contributors know what's happening.

[TomerPacific]

@djsmith85 - Reading the Contributing Guidelines and having a Windows machine, it seems like it would take some time for me to set up a local development environment properly. Wanted to communicate this and to allow anyone else to work on this issue if they want to.