directory-connector icon indicating copy to clipboard operation
directory-connector copied to clipboard

[PS-1239] If a group name is too long, shorten it to 100 characters

Open hajekj opened this issue 3 years ago • 2 comments

Type of change

  • [x] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ ] Other

Objective

When a group originating from Azure AD has more than 100 characters in its name, the entire import will fail. This PR shortens every group name to the maximum of 100 characters to make sure the import passes.

Code changes

Testing requirements

N/A, bugfix.

Before you submit

  • [x] I have checked for linting errors (npm run lint) (required)
  • [x] I have added unit tests where it makes sense to do so (encouraged but not required)
  • [ ] This change requires a documentation update (notify the documentation team)
  • [ ] This change has particular deployment requirements (notify the DevOps team)

hajekj avatar Jul 13 '22 15:07 hajekj

@vgrassia could somebody look into this PR please?

hajekj avatar Aug 03 '22 11:08 hajekj

Hi @hajekj , thank you for opening this PR. This has been added to our internal board for review. We'd get back to you with our feedback and/or concerns. Very appreciated!

dbosompem avatar Aug 10 '22 12:08 dbosompem