contributing-docs icon indicating copy to clipboard operation
contributing-docs copied to clipboard

ADR for usage of gRPC for networking between services

Open cturnbull-bitwarden opened this issue 1 year ago • 2 comments

🎟️ Tracking

Originated out of https://bitwarden.atlassian.net/wiki/spaces/EN/pages/809828356/Proposal+The+Pricing+Plans+Service

📔 Objective

This PR introduces a new ADR titled "Adopting gRPC for Inter-Service Communication". The purpose is to document the decision-making process and outcomes regarding adopting gRPC for inter-service communication within Bitwarden's microservices architecture.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cturnbull-bitwarden avatar Nov 20 '24 19:11 cturnbull-bitwarden

Logo Checkmarx One – Scan Summary & Detailsb6b15e7e-73aa-4173-94a5-bce3fcf5a59b

No New Or Fixed Issues Found

github-actions[bot] avatar Nov 20 '24 19:11 github-actions[bot]

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86940bc
Status: ✅  Deploy successful!
Preview URL: https://0091685f.contributing-docs.pages.dev
Branch Preview URL: https://adr-24-grpc.contributing-docs.pages.dev

View logs

@cturnbull-bitwarden for what it's worth, it could still be a good idea to finish this and then merge it as rejected -- I'd rather it not disappear as a closed PR.

withinfocus avatar Jul 08 '25 14:07 withinfocus