clients icon indicating copy to clipboard operation
clients copied to clipboard

[CL-233] Update form field styles

Open vleague2 opened this issue 1 year ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

CL-233

📔 Objective

This PR updates the styles for form field elements according to the new design spec for the extension refresh project.

Most of this PR is component library files. There is one breaking change to the form field API, which necessitated changes to a few other files.

This PR will get merged into the extension refresh feature branch.

📸 Screenshots

Check the "Storybook Publish" action and click the link to view the stories for Form (specifically, all the Field stories, Multiselect, and Password Toggle).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

vleague2 avatar Jun 21 '24 14:06 vleague2

Codecov Report

Attention: Patch coverage is 53.12500% with 30 lines in your changes missing coverage. Please review.

Project coverage is 29.35%. Comparing base (0bfbba2) to head (0fa21b9).

Files Patch % Lines
...bs/components/src/form-field/form-field.stories.ts 0.00% 9 Missing :warning:
libs/components/src/form-field/prefix.directive.ts 40.00% 6 Missing :warning:
.../components/src/form-field/form-field.component.ts 64.28% 1 Missing and 4 partials :warning:
libs/components/src/input/input.directive.ts 54.54% 4 Missing and 1 partial :warning:
.../components/src/form-field/multi-select.stories.ts 0.00% 2 Missing :warning:
libs/components/src/form-field/suffix.directive.ts 87.50% 0 Missing and 1 partial :warning:
libs/components/src/select/select.component.ts 0.00% 1 Missing :warning:
libs/components/src/select/select.stories.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##           ps/extension-refresh    #9776      +/-   ##
========================================================
- Coverage                 29.69%   29.35%   -0.35%     
========================================================
  Files                      2550     2527      -23     
  Lines                     74552    73790     -762     
  Branches                  13946    13776     -170     
========================================================
- Hits                      22138    21659     -479     
+ Misses                    50749    50503     -246     
+ Partials                   1665     1628      -37     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 21 '24 14:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – b4701755-1cd6-4c09-868c-56d6d00c667e

No New Or Fixed Issues Found

github-actions[bot] avatar Jun 21 '24 14:06 github-actions[bot]

@vleague2 would we be able to have a story with a long label added? I tried using the inspector to just change the label but it didn't update the cropped border right.

danielleflinn avatar Jun 28 '24 16:06 danielleflinn