clients icon indicating copy to clipboard operation
clients copied to clipboard

Creating a landing page for SM, where user can request access from ad…

Open cd-bitwarden opened this issue 1 year ago • 3 comments

…mins

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1211

📔 Objective

Create a landing page for Secrets Manager inside of Password Manager's sidebar, redirect to a request access page if the user logged in isn't the admin, redirect to create org if they aren't a part of any org, and redirect to the subscription page in admin console if they are the org admin.

📸 Screenshots

image## ⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cd-bitwarden avatar Jun 04 '24 18:06 cd-bitwarden

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Project coverage is 31.62%. Comparing base (fd93c76) to head (9dbf3a4).

Files Patch % Lines
...ets-manager-landing/request-sm-access.component.ts 0.00% 36 Missing :warning:
...er/secrets-manager-landing/sm-landing.component.ts 0.00% 29 Missing :warning:
.../secrets-manager-landing/sm-landing-api.service.ts 0.00% 5 Missing :warning:
apps/web/src/app/oss-routing.module.ts 0.00% 2 Missing :warning:
...nager/models/requests/request-sm-access.request.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9504      +/-   ##
==========================================
- Coverage   31.66%   31.62%   -0.04%     
==========================================
  Files        2620     2624       +4     
  Lines       78251    78324      +73     
  Branches    14676    14685       +9     
==========================================
- Hits        24780    24773       -7     
- Misses      51590    51670      +80     
  Partials     1881     1881              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 18:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details21f09402-3c29-4eb9-a367-51655c83e8df

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /libs/vault/src/cipher-form/components/additional-options/additional-options-section.component.html: 11 Attack Vector
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/secrets-manager/secrets-manager-landing/sm-landing.component.html: 49 Attack Vector

github-actions[bot] avatar Jun 04 '24 18:06 github-actions[bot]

@cd-bitwarden looks like Auth has been removed from the scope, so I've removed myself from review. Let me know if anything changes.

rr-bw avatar Jun 26 '24 17:06 rr-bw

@mzieniukbw @vleague2 @Thomas-Avery could I please have your review on these two tiny changes requested by the QA team:

Changing a value in the messages file, and ordering the organizations by org name in the org drop down :)

cd-bitwarden avatar Jul 02 '24 19:07 cd-bitwarden

Hey @Thomas-Avery and @vleague2 there is a new scenario I had to code for this SM-Landing page. Scenario: where the logged in person is an Admin (they do not have permission to go to the billing page), so they need to go to the request access page instead. If the logged in user is an Admin and the org does have SM enabled then we show them different content, explaining to them how to enable SM for a member. image

Could I please get your review on this? 😄

cd-bitwarden avatar Jul 16 '24 21:07 cd-bitwarden