clients
clients copied to clipboard
change tap to mergeMap
Type of change
- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Changes the tap
in the browser popup for message handling to be a mergeMap
. This is how we're handling it in the background and allows for async execution of messages.
Code changes
- file.ext: Description of what was changed and why
Screenshots
Before you submit
- Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
- Ensure that all UI additions follow WCAG AA requirements
Codecov Report
Attention: Patch coverage is 0%
with 40 lines
in your changes are missing coverage. Please review.
Project coverage is 27.63%. Comparing base (
5682e38
) to head (3300028
).
Files | Patch % | Lines |
---|---|---|
apps/browser/src/popup/app.component.ts | 0.00% | 40 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #9083 +/- ##
==========================================
- Coverage 27.63% 27.63% -0.01%
==========================================
Files 2416 2416
Lines 69875 69880 +5
Branches 13012 13013 +1
==========================================
Hits 19309 19309
- Misses 49067 49072 +5
Partials 1499 1499
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 6baa4c8e-585f-4d34-9121-c022d6fb868c