clients icon indicating copy to clipboard operation
clients copied to clipboard

Remove the scrollbar hack to remove vertical scrollbar

Open Hinton opened this issue 1 year ago • 2 comments

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We currently show a vertical scrollbar on some pages. This seems to have been caused by the attempt to prevent scrollbar jumping.

Screenshots

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Hinton avatar Feb 26 '24 17:02 Hinton

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.67%. Comparing base (cf0c5c5) to head (eaed987). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8097   +/-   ##
=======================================
  Coverage   24.67%   24.67%           
=======================================
  Files        2224     2224           
  Lines       65346    65346           
  Branches    12345    12345           
=======================================
  Hits        16125    16125           
  Misses      47897    47897           
  Partials     1324     1324           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 17:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details1432a954-4452-4747-9408-d93c3df38ace

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 26 '24 19:02 bitwarden-bot

Was merged as part of https://github.com/bitwarden/clients/pull/8151

Hinton avatar Mar 01 '24 17:03 Hinton