clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-5266] Create Avatar Service

Open rr-bw opened this issue 1 year ago • 3 comments

Type of change

  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)

Objective

Implements StateProvider in the AvatarService (formerly called the AvatarUpdateService), specifically refactoring the avatarColor property out of account.settings and into a StorageKey of user_user-example-123_avatar_avatarColor

Screencast

https://github.com/bitwarden/clients/assets/102181210/272494c9-f1b2-4f34-9e54-443e42e28ae4

rr-bw avatar Feb 12 '24 05:02 rr-bw

Codecov Report

Attention: Patch coverage is 34.48276% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 25.79%. Comparing base (ebf51eb) to head (a1db6c2). Report is 1 commits behind head on main.

Files Patch % Lines
...pup/account-switching/current-account.component.ts 0.00% 13 Missing :warning:
libs/common/src/auth/services/avatar.service.ts 0.00% 11 Missing :warning:
...ground/service-factories/avatar-service.factory.ts 0.00% 8 Missing :warning:
...sktop/src/app/layout/account-switcher.component.ts 0.00% 3 Missing :warning:
...p/auth/settings/account/change-avatar.component.ts 40.00% 3 Missing :warning:
...rations/37-move-avatar-color-to-state-providers.ts 86.95% 2 Missing and 1 partial :warning:
apps/browser/src/background/main.background.ts 0.00% 2 Missing :warning:
apps/cli/src/bw.ts 0.00% 2 Missing :warning:
...web/src/app/components/dynamic-avatar.component.ts 50.00% 1 Missing and 1 partial :warning:
...ault/components/vault-items/vault-items.stories.ts 0.00% 2 Missing :warning:
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7905      +/-   ##
==========================================
+ Coverage   25.76%   25.79%   +0.02%     
==========================================
  Files        2271     2272       +1     
  Lines       66387    66410      +23     
  Branches    12470    12475       +5     
==========================================
+ Hits        17105    17128      +23     
+ Misses      47931    47930       -1     
- Partials     1351     1352       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 05:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details32289839-6deb-4965-a81e-43e5801346de

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 12 '24 07:02 bitwarden-bot

CLI is failing, probably just a missed dependency

jlf0dev avatar Feb 19 '24 20:02 jlf0dev

@justindbaur Thanks! Merged main and fixed the conflict.

rr-bw avatar Mar 12 '24 21:03 rr-bw