clients
clients copied to clipboard
[PM-5266] Create Avatar Service
Type of change
- Tech debt (refactoring, code cleanup, dependency upgrades, etc)
Objective
Implements StateProvider in the AvatarService
(formerly called the AvatarUpdateService
), specifically refactoring the avatarColor
property out of account.settings
and into a StorageKey of user_user-example-123_avatar_avatarColor
Screencast
https://github.com/bitwarden/clients/assets/102181210/272494c9-f1b2-4f34-9e54-443e42e28ae4
Codecov Report
Attention: Patch coverage is 34.48276%
with 57 lines
in your changes are missing coverage. Please review.
Project coverage is 25.79%. Comparing base (
ebf51eb
) to head (a1db6c2
). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7905 +/- ##
==========================================
+ Coverage 25.76% 25.79% +0.02%
==========================================
Files 2271 2272 +1
Lines 66387 66410 +23
Branches 12470 12475 +5
==========================================
+ Hits 17105 17128 +23
+ Misses 47931 47930 -1
- Partials 1351 1352 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 32289839-6deb-4965-a81e-43e5801346de
No New Or Fixed Issues Found
CLI is failing, probably just a missed dependency
@justindbaur Thanks! Merged main and fixed the conflict.