Extension causing double execution of code

[jjspace]

trafficstars

Steps To Reproduce

1. clone https://github.com/CesiumGS/cesium
2. run npm install
3. run npm run build
4. run npm run build-docs - optional to avoid an extra console error, issue happens regardless
5. run npm start
6. Navigate to this local sandcastle example
7. Open the console
8. Observe test getting logged twice instead of just once
9. Reload and/or press Run (F8) to rerun the code playground. It seems to happen periodically sometimes

Expected Result

Code in Sandcastle should only be run once as in every other code playground.

Actual Result

Something with the Bitwarden extension is causing the code in Sandcastles to execute twice instead of once. This can break many examples that expect variables or entities to only be defined once.

This seems to be slightly sporadic but I have reproduced it with a fresh chrome profile that only has the Bitwarden extension installed. It seems to only happen after the extension is logged in. Even if it locks again waiting for the master password.

Even more bizarre, I can't reproduce this on the deployed version of Sandcastle. The same example above can be found here

I suspect it may have something to do with iframes and how bitwarden treats them loading. In the chrome profiler it looks like the window.startup is getting triggered twice only when it double runs the code so that seems to be the surface level cause but I have no idea why Bitwarden would cause that to happen.

Screenshots or Videos

https://github.com/bitwarden/clients/assets/8007967/3c7a3960-4d9f-47e1-aaaa-cb2e4d858dcd

Additional Context

No response

Operating System

Linux

Operating System Version

No response

Web Browser

Chrome, Brave

Browser Version

Chrome Version 121.0.6167.139, Brave Version 1.62.156 Chromium: 121.0.6167.139

Build Version

Extension Version 2024.1.1, Server 2024.1.2

Issue Tracking Info

• [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

[Greenderella]

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

[jjspace]

@Greenderella any update on this? It's still happening for me and it affects my daily workflow. I've been getting around it using a Guest profile but that's really not ideal. I don't have any more information other than I can consistently reproduce it for Chrome and Brave even after restarts of my browser and my computer.

I'm happy to try and schedule a time to hop on a call with a dev if that's going to help (I'd rather not put personal info in a GH comment though so I will need some other way to connect)

[cagonzalezcs]

@jjspace

As of this moment, we don't have a definitive reason for why this is happening or how to fix it. That said, I dug around a bit to see why this might be occurring, and I believe I might have found a smoking gun for our team to investigate.

In the meantime, if you turn off the recently introduced Passkeys feature, your described issue should no longer be present.

This can be done by going to Settings > Options > Ask to save and use passkeys within the extension.

[jjspace]

@cagonzalezcs That's great news! I can confirm switching off that passkeys option seems to have stopped the issue from happening. :pray: (will update if I spot it again)

That solution's actually fine for me right now since I don't even use the passkeys feature yet. But hopefully confirming that fixes it in the short term helps point to the true cause.