clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-1935] Migrate vault lock screen to component library

Open Hinton opened this issue 2 years ago • 7 comments

Ticket

https://bitwarden.atlassian.net/browse/PM-1935

Objective

Migrate the vault lock screen to the component library with AnonLayout.

  • Migrate to bitSubmit requires that we do it on all clients.

Screenshot

Screenshot 2024-06-03 at 11 38 22 AM

Hinton avatar Sep 08 '23 16:09 Hinton

Logo Checkmarx One – Scan Summary & Details72ce384e-9ee3-40f9-8d27-8b9f2fff6a05

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/lock.component.html: 18
MEDIUM Client_Privacy_Violation /apps/desktop/src/auth/lock.component.html: 32

bitwarden-bot avatar Sep 08 '23 17:09 bitwarden-bot

@djsmith85 it's not a component the CL team will support. It's strictly for sharing the container behavior for the auth pages and avoid inconsistencies which has already started to appear.

Hinton avatar Oct 13 '23 08:10 Hinton

@djsmith85 it's not a component the CL team will support. It's strictly for sharing the container behavior for the auth pages and avoid inconsistencies which has already started to appear.

Then into libs/auth? Tools will need the card.component for the send/access.component. Or the card.component`will be part of the AnonLayout which the SendAccess page will use?

djsmith85 avatar Oct 13 '23 09:10 djsmith85

@Hinton Is this still in being worked on? I'm happy to review once merge conflicts are resolved. No rush from me though.

rr-bw avatar May 08 '24 19:05 rr-bw

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (432a4dd) to head (d6f1fb0). Report is 29 commits behind head on main.

Files Patch % Lines
apps/web/src/app/auth/lock.component.ts 0.00% 15 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6237      +/-   ##
==========================================
+ Coverage   29.53%   29.66%   +0.13%     
==========================================
  Files        2538     2550      +12     
  Lines       74167    74568     +401     
  Branches    13858    13947      +89     
==========================================
+ Hits        21905    22122     +217     
- Misses      50603    50784     +181     
- Partials     1659     1662       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 21 '24 09:05 codecov[bot]

@rr-bw this PR has been pending review for 7 months. I rebased it on request but I don't have the capacity in the forseeable future to allocate any resources to expanding the scope of the PR. The Auth team is welcome to take ownership of the PR.

Hinton avatar May 22 '24 09:05 Hinton

@Hinton Yes I think that's best. I talked with Todd and Auth will take it from here.

rr-bw avatar May 22 '24 16:05 rr-bw

Design nit: Could we change the title to just "Your vault is locked"? It feels really long right now and I think entering the MP to unlock is implied.

danielleflinn avatar Jul 03 '24 19:07 danielleflinn