clients icon indicating copy to clipboard operation
clients copied to clipboard

Autofill shortcut doesn't do anything

Open Lippiece opened this issue 1 year ago • 29 comments

Steps To Reproduce

  1. Open a login form with a login saved for its web address.
  2. Press autofill shortcut.

Expected Result

Login and password to be filled.

Actual Result

Nothing happens.

Operating System

Windows, Linux

Operating System Version

Windows 10, OpenSUSE Tumbleweed

Web Browser

Vivaldi

Browser Version

5.8.2970.3 (Official Build) snapshot (64-bit)

Build Version

2023.3.0

Issue Tracking Info

  • [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

Lippiece avatar Apr 02 '23 07:04 Lippiece

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

c1-jack avatar Apr 03 '23 05:04 c1-jack

Hello, I have the same issue on Google Chrome. My computer runs on Windows 11.

LVMVRQUXL avatar Apr 06 '23 06:04 LVMVRQUXL

I am having the same issue in Vivaldi on macOS 12.6.3 (21G419).

Also, if I change the keyboard shortcut to Ctrl-Cmd-Shift-L, then click on Settings > Autofill in the extension window, it says the keyboard shortcut is not set; it seems to do this for shortcuts involving the Ctrl key.

unikitty37 avatar Apr 27 '23 14:04 unikitty37

I have the same issue and it seems that the situation here is connected to this issue https://github.com/bitwarden/clients/issues/2483

I have two browsers running (on Linux, btw, so the problem affects both Windows and Linux), both have bitwarden plugin, and hotkeys works in one browser only.

GRbit avatar Sep 19 '23 10:09 GRbit

This has been broken for me for quite some time since they changed the shortcut to Auto-fill the last used login for the current website. But even that doesn't work. Doesn't matter if I've used my one and only login on a site 50 times today, it still won't autofill with the hotkey.

ghost avatar Oct 05 '23 14:10 ghost

I'm also seeing this in Firefox on macOS Sonoma.

Until I figure out what's stealing ⌘ + ⇧ + L, in the interim I've assigned BitWarden's auto-fill ⌘ + ⇧ + M image

Go to Extensions > Gear > Manage Extension Shortcuts

coryfklein avatar Oct 17 '23 16:10 coryfklein

I'm also seeing this in Firefox on macOS Sonoma.

Until I figure out what's stealing ⌘ + ⇧ + L, in the interim I've assigned BitWarden's auto-fill ⌘ + ⇧ + M

You're definitely onto something! I changed it to something else as well and it seems to be happy. Definitely wondering what is hijacking ⌘⇧L... 🤔

ghost avatar Oct 17 '23 19:10 ghost

I wanted to chime in that I'm seeing this bug on Firefox on Linux as well; that too, on two seprate devices. I checked the extension shortcuts—the auto-fill short cut is left as default, ctrl+shift+l.

jeenuv avatar Oct 21 '23 17:10 jeenuv

Weird, this morning now suddenly my new ⇧ ⌘ M keyboard shortcut stopped working, but I used the instructions above to set it back to ⇧ ⌘ L and now that is working again.

coryfklein avatar Nov 07 '23 16:11 coryfklein

You can still use whatever shortcuts you want. I've found you first have to clear them all, restart your browser, then set them again. In that order. Simply clearing and re-assigning will NOT work.

This has been happening on and off for months now, across all desktop platforms and always seems to coincide with an update. Apparently updating the extension randomly breaks shortcuts, but they still show in the GUI as set. Clearing them and then restarting the browser seems to force the extension to recreate the actual mapping in the browser, solving the problem, at least until the next update rolls out.

v8d avatar Nov 08 '23 07:11 v8d

I've found you first have to clear them all, restart your browser, then set them again. In that order. Simply clearing and re-assigning will NOT work.

I have to admit that I didn't expect this to work, but it did.

ewjoachim avatar Nov 08 '23 13:11 ewjoachim

This has been happening on and off for months now, across all desktop platforms and always seems to coincide with an update.

This is 100% correlated with a pending update for me.

michaelkvance avatar Nov 09 '23 02:11 michaelkvance

Ah, I had the update later on that same day, so for me the bug was solved by restarting FF a few hours before I had to re-restart FF for the update.

ewjoachim avatar Nov 09 '23 09:11 ewjoachim

Right, apologies if I was unclear, my shortcuts work fine until FF props an update in the background, then the shortcuts stop working. Upon restart the shortcuts start working again. This may be cargo cult thinking, it's hard to catch exactly, but it feels like the correlation I see.

michaelkvance avatar Nov 09 '23 12:11 michaelkvance

I would like to add that I am also seeing this bug across multiple Firefox Windows clients, FF 119.0.1 currently. Interestingly, the shortcut appears to work in Private Window, but not the normal window. I double checked all my extensions, even enabling the exact same ones in Private Window, and the Ctrl+Shift+L shortcut still worked in Private Window but not the normal window. So, I'm not sure why it works in Private even with the same extension set, but that is something to consider. Can anyone else reproduce this?

SizableShrimp avatar Nov 14 '23 22:11 SizableShrimp

Interestingly, the shortcut appears to work in Private Window, but not the normal window.

I'm experiencing the same in Firefox 120.0b6 (64-bit) on MacOS 13.5.2 (22G91). Stops working after a while in normal windows, but still works in a private window.

poacher2k avatar Nov 17 '23 09:11 poacher2k

I've found that the shortcuts only work when I start smashing them. I don't know how many tries it takes, but eventually it does autofill, but I have to do to it multiple times. Restarting doesn't work for me, only smashing the keys over and over again.

Necronar avatar Dec 01 '23 21:12 Necronar

Shoutout to @v8d above. His temporary workaround does work.

Another thing I noticed with this (in Firefox at least): If keyboard shortcuts to autofill aren't working, and I take the affected browser tab and make it it's own window (by dragging the tab to the desktop), the autofill keyboard shortcuts start working again for the new window. If I drag the tab back in a group with other tabs, they stop working. Just another bit of evidence that might be useful in troubleshooting.

lwimbleCIP avatar Dec 13 '23 14:12 lwimbleCIP

@lwimbleCIP Thanks much for this workaround, it also solved the problem for me. In fact, when I created a new window and dragged all the tabs from the old window to it, the Bitwarden shortcut still worked in the new window, so seemingly whatever state was "broken" pertains to the (old) window and not to (as I'd guessed might have been the case) some particular sibling tab that was interfering somehow with the tab I was trying to use the Bitwarden shortcut in. As a further data point, when I had previously restarted firefox and restored old tabs/windows with Ctrl-Shift-T, the "brokenness" persisted with the window.

Or to put it more concretely, here's what I observed:

Window 1 [ Tab A, Tab B, Tab C] Window 2 [ ] # Bitwarden autofill shortcut *not* working in Tab C
# move tab C to its own window:
Window 1 [ Tab A, Tab B ] Window 2 [ Tab C ] # Bitwarden autofill shortcut *working* in Tab C
# move tab C back to see what happens:
Window 1 [ Tab A, Tab B, Tab C] Window 2 [ ] # Bitwarden autofill shortcut *not* working in Tab C
# move all tabs to new window:
Window 1 [ ] Window 2 [ Tab A, Tab B, Tab C ] # Bitwarden autofill shortcut *working* in Tab C
# move *just* tab C back:
Window 1 [ Tab C ] Window 2 [ Tab A, Tab B ] # Bitwarden autofill shortcut *not* working in Tab C

jcreedcmu avatar Dec 17 '23 16:12 jcreedcmu

It feels like this discussion should probably be in Firefox's issue tracker rather than in Bitwarden's.

ewjoachim avatar Dec 18 '23 13:12 ewjoachim

Definitely a shoutout to @v8d for the workaround.

kennethhlee avatar Dec 23 '23 18:12 kennethhlee

Had this problem before on Windows while using Firefox. I have both edge + firefox extensions, it seems that edge takes priority in shortcut before firefox. Either kill msedge process or turn off "run in background" for edge.

Previous issue : #2483

justinmahendra avatar Jan 06 '24 10:01 justinmahendra

Hello everyone,

I've taken some time to review this issue and attempted to dig into a possible reason for why it might be happening. I'm still not sure on the reason for the issue, whether it's due to some kind of OS-based focus order priority (as has been discussed by @justinmahendra) or some kind of issue with how we handle registration of the shortcut.

I did find some potential evidence for why this might be happening on an old Reddit thread and Mozilla bug report. These two links detail some form of de-registration that is happening in Firefox when an extension keyboard shortcut is associated with copying values to the user's clipboard. I'm not sure if this bug poses a direct reason for why this might be happening, but given that the autofill shortcut can trigger a copy of a cipher's TOTP, it's potentially viable.

It seems more often than not that this keystroke issue happens shortly after the extension has updated in an existing Firefox browsing session. When possible, I'm going to explore some potential solutions with de-registering the keyboard shortcuts when the extension is being reloaded or updated. On re-init of the extension, the keyboard shortcuts would be re-registered as usual.

Hoping to be able to provide some kind of resolution soon.

cagonzalezcs avatar Jan 19 '24 19:01 cagonzalezcs

By the way, I don't have this issue for a long time already. Autofill works flawlessly.

Lippiece avatar Jan 20 '24 09:01 Lippiece

@Lippiece Thanks for that, though we've seen reports of the issue appear in a regular manner... at least once a month since first being reported, though usually not by a large number of individuals.

Seems to be really intermittent, but still worth investigating.

cagonzalezcs avatar Jan 21 '24 18:01 cagonzalezcs

I think there's something specific about ctrl+shift+l. I haven't had issues since I switched to alt+shift+w, and I reswitch from times to times, and still have issues with ctrl+shift+l. But then maybe it's just a coincidence.

ewjoachim avatar Jan 21 '24 19:01 ewjoachim

I see this happening often, Mac on Firefox, when I just start Firefox it works just fine, but after a few days it stops working. I tried to find ways to debug this (Developer Tools, etc. to snoop on keyboard shortcuts of Firefox, ShortcutDetective app on Mac) but couldn't find a way to figure that out why this wasn't working. I have a Firefox with this problem now, if you'd like me to run some commands to inspect the state of something, let me know, I'd be glad to help out with a reproducer. Thanks!

filbranden avatar Jan 30 '24 21:01 filbranden

Ctrl+Shift+L was not working, so I tried to re-bind it. When I hold Ctrl+Shift, and tap L, I get Ctrl+Shift+L and an error "Press a letter". I can bind Alt+L, or Alt+Shift+L, but now that I've deleted the shortcut I can't add it back.

Firefox 122.0 Windows 11 23h2 Bitwarden 2024.1.1

mrlinuxfish avatar Feb 04 '24 01:02 mrlinuxfish

I've been seeing this for maybe 6 months now, on Firefox on my Macbook. A restart of firefox solves it for a few days, and then it starts again. Once it starts, it will not stop before a firefox restart. I'm using Cmd + Shift + L

I'm also using Bitwarden for Firefox on W11 but still haven't seen the problem there. There I'm using the standard Ctrl + Shift + L

Frikeer avatar Feb 22 '24 16:02 Frikeer

Just wanted to chime in that this issue exists for other Bitwarden keyboard shortcuts as well, specifically Cmd+Shift+Y, which is supposed to open the sidebar.

I notice that when I press Cmd+Shift+Y, the menu bar flashes, which indicates that the keyboard shortcut is registered on some level, even though the sidebar doesn't actually open. If I manually open the menu and click then entry, it opens. Very strangely, the keyboard shortcut works while the menu is open! Very strange. See the video below.

https://github.com/bitwarden/clients/assets/4657140/a5bed027-5c72-4139-acb8-2ca8812c22c4

I'm on Firefox on macOS Sonoma.

Asheq avatar Mar 16 '24 02:03 Asheq