clients icon indicating copy to clipboard operation
clients copied to clipboard

[EC-855] Add block and hint support to radio button component

Open jlf0dev opened this issue 2 years ago • 3 comments

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

add block support to radio button component

Screenshots

See Chromatic for Design Review

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

jlf0dev avatar Dec 21 '22 14:12 jlf0dev

@bitwarden/dept-design Can you verify that the padding between options here looks correct? There's a couple different examples in figma so I wanted to find a decent standard. image

(also feel free to check out the Chromatic as well)

jlf0dev avatar Dec 21 '22 18:12 jlf0dev

@jlf0dev Can we do no margin between the hint and radio button? Then between each hint/radio button group can we do .5rem of margin?

danielleflinn avatar Dec 21 '22 19:12 danielleflinn

After a quick design review, we need to make some bigger layout changes to the radio component. Converting to a draft for now.

jlf0dev avatar Dec 21 '22 19:12 jlf0dev