clients icon indicating copy to clipboard operation
clients copied to clipboard

[PS-1845] let node-ipc use individual pipes on Windows

Open onjonjo opened this issue 3 years ago • 2 comments

This fixes an issue with multiple users on Windows. There should be an individual Windows pipe used for communication between browser plugin and desktop for each user. However, the naming scheme used the same name for every user. This change adds some uniqueness with a hash over username and unique directory name.

Type of change

- [X ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes bug with multiple users on Windows.

fixes #3894 fixes #2586 fixes #3817 fixes #1587

Code changes

  • ipc.ts: Configures individual name for IPC named pipe on Windows

Tests

The Code was sucessfully tested on Windows 10 with two users (my home setup). Now me and my wife can use Bitwarden at the same time.

onjonjo avatar Nov 09 '22 06:11 onjonjo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 09 '22 06:11 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1845

bitwarden-bot avatar Nov 09 '22 06:11 bitwarden-bot

Hey guys, also facing the same issue on multi user windows environment. Any updates on this fix?

thx

popy2k14 avatar Jan 19 '23 18:01 popy2k14

ping... Is there anything preventing this PR from being reviewed?

onjonjo avatar Feb 05 '23 14:02 onjonjo

Please merge. This issue comes up everytime one of my other family members is using the PC. Thx

popy2k14 avatar Feb 25 '23 08:02 popy2k14

Hi @onjonjo,

QA has given this the green light, and we'll perform the last testing once this is merged to master. Thanks for the contribution.

Hinton avatar Apr 11 '23 14:04 Hinton

Thanks a lot for merging! When can we expect to see this in an release?

popy2k14 avatar Apr 22 '23 10:04 popy2k14

For anyone like me, who is waiting on this. Since the new release "Desktop v2023.4.0": https://github.com/bitwarden/clients/releases/tag/desktop-v2023.4.0 Multi User Windows hello is finally working.

thx

popy2k14 avatar May 02 '23 18:05 popy2k14