clients icon indicating copy to clipboard operation
clients copied to clipboard

[PS-1211] Added autofill for textareas

Open mr-manuel opened this issue 3 years ago • 2 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Be able to use autofill also for textareas. https://github.com/bitwarden/clients/issues/1966

Code changes

  • https://github.com/mr-manuel/bitwarden_autofill_clients/commit/dbb7b6ec6d9e1a3700514d82cc8b00048480cd7b Added textarea tag in order to use autofill also on textareas.

Before you submit

- [ ] I have checked for **linting** errors (`npm run lint`) (required)
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

mr-manuel avatar Jul 28 '22 05:07 mr-manuel

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 28 '22 05:07 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1211

bitwarden-bot avatar Jul 28 '22 05:07 bitwarden-bot

Any updates on this?

mr-manuel avatar Nov 30 '22 06:11 mr-manuel

Hi @mr-manuel, thank you for your time and contribution to Bitwarden.

Unfortunately, as you closed this PR and deleted your repo (fork), we currently cannot accept/review your contribution. The internal ticket, tracking this, got moved out of the review prioritization.

I want to apologize for the long wait to get this reviewed, prior to you closing this, though. Any changes related to auto-fill, currently involve a lot of manual testing, which we need to allot more time than usual for. We are planning on adding a more automated test-suite, hopefully soon. This should improve future review times.

Please re-open a new PR with your changes, and I'll round this up for review.

Kind regards, Daniel

djsmith85 avatar Nov 30 '22 11:11 djsmith85

Hi @djsmith85,

since this are two very small changes I thought the repo is not neccessary. Anyway I recreated the fork and did a new pull request. https://github.com/bitwarden/clients/pull/4155

mr-manuel avatar Nov 30 '22 14:11 mr-manuel