clients icon indicating copy to clipboard operation
clients copied to clipboard

[PS-1099] Refactor provider service

Open djsmith85 opened this issue 1 year ago • 0 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Part of work described in: https://bitwarden.atlassian.net/browse/PS-1075

Split out provider-api methods from api-service Separate read/write methods on provider service and expose write-methods only when necessary

Code changes

  • libs/common/src/abstractions/api.service.ts and libs/common/src/services/api.service.ts: Removed provider-related api calls

  • libs/common/src/abstractions/provider/provider-api.service.abstraction.ts and libs/common/src/services/provider/provider-api.service.ts: New provider-api.service.

  • libs/angular/src/services/jslib-services.module.ts: Register new ProviderApiService

  • Rest of the files: Change of imported/used abstraction

Before you submit

- [X] I have checked for **linting** errors (`npm run lint`) (required)
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

djsmith85 avatar Jul 15 '22 15:07 djsmith85