clients Email verfication invalid state

Describe the Bug

A break in the email verification flow leads to invalid application state.

Steps To Reproduce

Register for new account
Login
Click "send verification email"
Open verification email, click link
(Web browser opens to vault login screen [even if logged in in another tab]; Green "email verified" status banner appears)
Do not log in; instead, close the tab (because of course you are logged in in an adjacent tab
Optionally refresh the adjacent, logged in tab, but this step probably does seem to affect state
Unverified email box still appears -- click "send verification email"
A red warning banner pops up indicating that the email verification has already been sent

The only way out of this invalid state, as far as I can tell, is to go back to the original email and re click the link, and successfully login.

Expected Result

Email verification flows should always offer the option to re-send the email

Actual Result

Clicking the "send verification email" warns the user that email was already sent (too bad)

Screenshots or Videos

Didn't think to capture

Environment

Firefox 84.0.1

Jan 04 '21 04:01 jblachly

Clarifying question: when the warming about the verification email already being sent is shown, I'm assuming a new email is not sent? And/or that there is no option to proceed from/past that warning?

Jan 08 '21 21:01 apmarshall

Correct: new emails are not sent in response to the warning.

Jan 08 '21 21:01 jblachly

Hi @jblachly, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

Apr 12 '22 19:04 bitwarden-bot

I mean, you can mark it stale, but if it wasn't ever addressed it seems unwise to close it just because the developers aren't commenting on it and keeping it active.

Apr 13 '22 13:04 jblachly

Hey @jblachly after following the steps, it appears the error message is actually verifying that the email has already been confirmed and can be resolved by logging out and back in. We can definitely improve this by intercepting the error message, so thank you for the feedback.