clients icon indicating copy to clipboard operation
clients copied to clipboard

Vault always lock if you set a timeout or browser restart without quitting Chrome.

Open rafa2mac opened this issue 2 years ago • 22 comments

Steps To Reproduce

  1. Open the browser vault settings in Chrome
  2. Set the Vault Timeout "On Browser Restart" or any kind of time minutes (Lock or Logout)
  3. Close every single page on Mac without actually quitting the browser.
  4. Open a new page.

Expected Result

The vault is not locked. It would lock once the time previously set expired or if you totally quit chrome (CMQ+Q)

Actual Result

The vault lock every time you reopen a new window even though the time set is not expired or if the Chrome was not closed.

Screenshots or Videos

No response

Additional Context

I tested the extension in Firefox and Safari: it is working ok. When you select "On Browser restart" you close all the windows without quitting the actual browser, you reopen a new page: the vault had not locked.

I also can confirm that the issue wasn't happening with Chrome 97.0.4692.71. I was able to downgrade and check that it works properly. The problem is with 98.0.4758.80.

Operating System

macOS

Operating System Version

12.2.1

Web Browser

Chrome

Browser Version

98.0.4758.80

Build Version

1.56.5

rafa2mac avatar Feb 15 '22 23:02 rafa2mac

Yep, same here, and it's pretty annoying.

It looks like a recent, big update caused this. Recommend fixing this whenever you're able because we truly love and appreciate your hard work. Peace out.

binarykitchen avatar Feb 16 '22 07:02 binarykitchen

Yep, same here, and it's pretty annoying.

It looks like a recent, big update caused this. Recommend fixing this whenever you're able because we truly love and appreciate your hard work. Peace out.

Definitely agree! The password manager is one of the best. Look forward to seeing this bug resolved.

rafa2mac avatar Feb 16 '22 16:02 rafa2mac

I have the bug too :'( it is quite annoying. For me the bug happens quite randomly: after some period of time my bitwarden on all my computers that use Chrome locks out even thought I have chosen "Browser restart" timeout.

tcosmo avatar Feb 16 '22 22:02 tcosmo

Happening to me as well even though I have mine set to "never", I've even tried setting a custom time with the time set to 250000 hours and it'll still randomly lock itself and well I don't think it's been anywhere near 250000 hours (28 years) since it was last locked xD Would love to see this fixed!

JourneyOver avatar Feb 16 '22 23:02 JourneyOver

I've managed to replicate this on chrome version 98 on macOS using the vault timeout "On Restart". Unfortunately there's not much we can do from our side, the extension background page is completely removed when all chrome windows are closed which prevents us from safely storing any state.

As to sporadic locking, I suspect that happens when the extension gets updated automatically by Chrome which also reloads the state. As we released a few hotfixes during the last couple of days this probably occurred a bit more frequently than usual.

Hinton avatar Feb 17 '22 08:02 Hinton

Same issue here on Windows and Chrome 98.

turkeyphant avatar Feb 17 '22 12:02 turkeyphant

Same problem here on macOS 10.14 and Chrome 98.0.4758.102. I use the setting system lock

wenkunst avatar Feb 17 '22 13:02 wenkunst

I've managed to replicate this on chrome version 98 on macOS using the vault timeout "On Restart". Unfortunately there's not much we can do from our side, the extension background page is completely removed when all chrome windows are closed which prevents us from safely storing any state.

This is very unfortunate. I tested today on Edge and it works properly. Are there any chrome://flags that can be changed to fix this? Thanks for your excellent work anyway

rafa2mac avatar Feb 17 '22 23:02 rafa2mac

I've managed to replicate this on chrome version 98 on macOS using the vault timeout "On Restart". Unfortunately there's not much we can do from our side, the extension background page is completely removed when all chrome windows are closed which prevents us from safely storing any state.

LastPass manages to stay logged in.

As to sporadic locking, I suspect that happens when the extension gets updated automatically by Chrome which also reloads the state. As we released a few hotfixes during the last couple of days this probably occurred a bit more frequently than usual.

The sporadic locking I experience only happens when the timeout is set to a number, like 4 hours. And there's no way you're releasing updates one second after I unlock BW, over and over again.

swinggraphics avatar Mar 08 '22 16:03 swinggraphics

Is there any update that might fix this issue on chrome? Every other browser works fine. I have been for a few weeks on Edge and never had the issue described above.

rafa2mac avatar Mar 08 '22 21:03 rafa2mac

I want to report that the most recent updates of Google Chrome (99.0.4844.83 ) resolved the issue in version 1.56.6.

rafa2mac avatar Mar 22 '22 18:03 rafa2mac

Still broken here. Easy to reproduce. #2480

swinggraphics avatar Mar 29 '22 19:03 swinggraphics

Still broken - set to never and it locks constantly

WillFP avatar Mar 30 '22 11:03 WillFP

It worked properly for a couple of weeks but this morning I updated to the new Chrome 100.0.4896.60 and it's not working anymore.

rafa2mac avatar Mar 31 '22 14:03 rafa2mac

@WillFP That sounds like a different issue. I've had reports from others that it started working after reinstalling the extension.

Hinton avatar Mar 31 '22 14:03 Hinton

@WillFP That sounds like a different issue. I've had reports from others that it started working after reinstalling the extension.

It works on my end if I set it to never. It doesn't work with any other options. I have been using On Browser Restart for years and not each time the last Chrome page is closed, it gets locked. Sad cause I thought the issue was resolved with version 99. Today's update (100) broke the extension again. Wondering if the Bitwarden team can somehow communicate with the Chrome team to get this addressed. I really don't want to migrate to another browser.

rafa2mac avatar Mar 31 '22 15:03 rafa2mac

The Chromium bugtracker is publicly available at https://bugs.chromium.org/p/chromium/issues/list. We don't have any secret communication channel unfortunately.

Hinton avatar Mar 31 '22 15:03 Hinton

The Chromium bugtracker is publicly available at https://bugs.chromium.org/p/chromium/issues/list. We don't have any secret communication channel unfortunately.

Ok, understood. Hopefully this will be resolved.

rafa2mac avatar Mar 31 '22 15:03 rafa2mac

Update. I just tried Chrome Canary Version 102.0.4974.2 and the vault settings work properly. So hopefully the next updates of the regular Google Chrome will fix this.

rafa2mac avatar Mar 31 '22 15:03 rafa2mac

I get this behaviour on Mac, but without closing windows. Browser windows with tabs I have had open all day constantly lock themselves.

ndevenish avatar Jun 08 '22 18:06 ndevenish

Looks like this issue is caused by allowing the browser extension to run in private windows. On Firefox for MacOS, disabling this fixed the issue for me

ClickyCoyote avatar Jul 19 '22 22:07 ClickyCoyote

With the new versions of Chrome, the Vault Timeout it's totally useless. The only working thing is if you set on Never. This is a problem that has been going on for months.

rafa2mac avatar Aug 04 '22 15:08 rafa2mac

This problem still persists and is also present in Edge now.

lkeels avatar Oct 12 '22 00:10 lkeels

This problem still persists and is also present in Edge now.

Yes. I totally gave up on this. Now they state on their website that this is normal behaviour. I don't understand why keep the timeout options since they don't work if you close your browser.

rafa2mac avatar Oct 12 '22 13:10 rafa2mac

It's absolutely ridiculous. I'm having to unlock my vault almost as much as I'd have to type a password, making the product all but useless. It looks like going back to LastPass is the only way to get proper functionality back.

lkeels avatar Oct 12 '22 13:10 lkeels

As stated in https://github.com/bitwarden/clients/issues/2395#issuecomment-1042683224, this is unfortunately a change in browser behavior. Bitwarden only persists the state in memory, recent changes to Chromium causes our "background page" to be closed when no chrome windows are opened. This is unfortunately not something we can resolve at this point without persisting sensitive information to disk.

Hinton avatar Oct 17 '22 06:10 Hinton

And yet, LastPass can.

On Mon, Oct 17, 2022 at 2:27 AM Oscar Hinton @.***> wrote:

As previously mentioned, this is an upstream issue. Bitwarden only persists the state in memory, recent changes to Chrome causes our "background page" to be closed when no chrome windows are opened. This is unfortunately not something we can resolve at this point without persisting sensitive information to disk.

— Reply to this email directly, view it on GitHub https://github.com/bitwarden/clients/issues/2395#issuecomment-1280353173, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAYOBOMPJRFH2DED3BH22DWDTWV3ANCNFSM5OP7H26Q . You are receiving this because you commented.Message ID: @.***>

lkeels avatar Oct 17 '22 12:10 lkeels

With the stated reason that you can't keep track of time when the window closes without saving sensitive information to disk, there's additional absurdity here because BW will stay unlocked in Chrome when the app is quit and even when the entire system is restarted. Please, by all means, go ahead and save a tiny bit of "sensitive information" to disk, because without that, BW is just always unlocked, which is much less secure. It just doesn't make any sense.

swinggraphics avatar Oct 18 '22 00:10 swinggraphics

recent changes to Chromium causes our "background page" to be closed when no chrome windows are opened

Right, but it’s also doing it without closing chrome windows.

ndevenish avatar Oct 18 '22 00:10 ndevenish

I am having the same issue. I am using Chrome (109.0.5414.119) on Mac OS 12.6.2. No matter what i set the lockout to, Bitwarden always locks when i close all the windows and reopen. The only exception is when I set it to never and then it will not lock up. I never had this issue with Lastpass. It seems to work fine on Safari except if I quit Safari and go back in, Bitwarden is locked even though I set it to a four hour window but if I just close the window and go back in, it is still unlocked. Chrome locks Bitwarden if I close all the windows but I don't quit Chrome.

praiford98 avatar Jan 25 '23 17:01 praiford98