PM-28183 implemented new sends filter and search design
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-28183
đ Objective
Move search below the header and update filters to use a toggle group instead of the filter card.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Claude finished @bmbitwarden's task in 2m 24s ââ View job
Code Review Complete
Review completed. Findings have been posted as inline comments.
Checkmarx One â Scan Summary & Details â ee259893-0bd3-4fd8-89e8-5a8589d1eecf
New Issues (1)
Checkmarx found the following issues in this Pull Request
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
CVE-2025-68429 | Npm-storybook-9.1.16 | detailsRecommended version: 9.1.17Description: Storybook is a frontend workshop for building user interface components and pages in isolation. A vulnerability in versions from 7.x prior to 7.6.2... Attack Vector: NETWORK Attack Complexity: LOW ID: 4CPfJsnkU6ukumdcyBoJuqmPSmPdhV%2BlC210U3MP4C8%3D |
Codecov Report
:x: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.04%. Comparing base (5504d49) to head (7b7feee).
:warning: Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| apps/web/src/app/tools/send/send.component.ts | 0.00% | 26 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #17901 +/- ##
==========================================
- Coverage 42.06% 42.04% -0.02%
==========================================
Files 3592 3592
Lines 104305 104330 +25
Branches 15721 15727 +6
==========================================
- Hits 43876 43869 -7
- Misses 58564 58596 +32
Partials 1865 1865
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
How difficult would it be to place this change under the Send UI Refresh feature flag so that we can roll back functionality if needed? For any Send UI refresh code that we add, we should discuss any exceptions that won't be hidden behind the flag that was created for this effort
How difficult would it be to place this change under the Send UI Refresh feature flag so that we can roll back functionality if needed? For any Send UI refresh code that we add, we should discuss any exceptions that won't be hidden behind the flag that was created for this effort
just put this one behind DesktopSendUIRefresh feature flag
