clients icon indicating copy to clipboard operation
clients copied to clipboard

feat(redirect): [PM-26578] Https Redirection for Cloud Users - Initia…

Open Patrick-Pimentel-Bitwarden opened this issue 1 month ago • 2 comments

…l changes to webpack and the redirect calls.

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Logo Checkmarx One – Scan Summary & Detailsc9f8c5f1-e826-442d-83ce-67286ddc7bd4

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Dec 08 '25 20:12 github-actions[bot]

Codecov Report

:x: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.85%. Comparing base (fe4895d) to head (dd4b456). :warning: Report is 10 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/connectors/utils/callbackUri.ts 16.66% 10 Missing :warning:
apps/web/src/connectors/webauthn.ts 0.00% 7 Missing :warning:
apps/web/src/connectors/duo-redirect.ts 33.33% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17873   +/-   ##
=======================================
  Coverage   41.84%   41.85%           
=======================================
  Files        3589     3590    +1     
  Lines      104181   104200   +19     
  Branches    15712    15722   +10     
=======================================
+ Hits        43595    43613   +18     
+ Misses      58737    58735    -2     
- Partials     1849     1852    +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 08 '25 20:12 codecov[bot]