[PM-24978] Corrupt Attachment Keys

[nick-livefront]

🎟️ Tracking

PM-24978

📔 Objective

When a attachment key is invalid (for any reason) it would result in the attachment looking normal but would fail to download. Without a valid key we are unable to download an attachment.

• When the attachment key is invalid, show Error: Cannot decrypt message and hide the download button
• After discussing with Renee - updated the case for an invalid filename with the new Error: Cannot decrypt to match

📸 Screenshots

Web	Browser	Desktop

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude[bot]]

Claude finished @nick-livefront's task in 2m 21s —— View job

---

Code Review Complete ✓

The review has been completed. All feedback has been posted as inline comments and a summary review comment.

---

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – eae7004d-d8ac-4fca-97ea-f595d93243fc

Great job! No new security vulnerabilities introduced in this pull request

[codecov[bot]]

Codecov Report

:x: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.82%. Comparing base (44384d5) to head (be0cf5f). :warning: Report is 2 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...-view/attachments/attachments-v2-view.component.ts	20.00%	4 Missing :warning:
...onents/attachments/cipher-attachments.component.ts	0.00%	2 Missing and 1 partial :warning:
...bs/common/src/vault/models/view/attachment.view.ts	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17790      +/-   ##
==========================================
- Coverage   41.82%   41.82%   -0.01%     
==========================================
  Files        3588     3589       +1     
  Lines      104124   104170      +46     
  Branches    15691    15713      +22     
==========================================
+ Hits        43553    43565      +12     
- Misses      58727    58759      +32     
- Partials     1844     1846       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nick-livefront]

@shane-melton I had conflicts to fix! Re-requesting review

[nick-livefront]

@shane-melton Conflict fix in the messages.json file