[PM-28536] Add phishing blocker setting to account security
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-28536
đ Objective
Adds a user-level setting to allow users to disable the phishing detection feature in the browser extension. The setting applies to all users logged into the extension that have premium access.
- New Service: PhishingDetectionSettingsService manages the user on/off state
- UI: Added toggle in Account Security settings (visible to premium users only)
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 5ef85231-0761-4970-9622-df717bae2401
Great job! No new security vulnerabilities introduced in this pull request
Claude finished @maxkpower's task ââ View job
Review Complete â
- [x] Analyze PR context
- [x] Review PR changes using bitwarden-code-reviewer agent
- [x] Complete review
The bitwarden-code-reviewer agent has completed a comprehensive review of this PR and posted:
- 1 summary comment with overall assessment and recommendation
- 5 inline comments on specific code sections
The review findings and recommendations are now visible in the PR conversation. The code is production-ready and follows all critical Bitwarden guidelines.
Codecov Report
:x: Patch coverage is 71.15385% with 15 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.87%. Comparing base (dc763f6) to head (fd83388).
:warning: Report is 20 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #17527 +/- ##
==========================================
+ Coverage 41.84% 41.87% +0.02%
==========================================
Files 3589 3591 +2
Lines 104162 104236 +74
Branches 15713 15722 +9
==========================================
+ Hits 43590 43647 +57
- Misses 58722 58725 +3
- Partials 1850 1864 +14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I've addressed some comments as well as made an update to the UI component used as per design in the ticket. I've also fixed some merged whitespace changes that my local environment overwrote.
This pull request is ready for re-review.
We will be merging the code changes from 17818 into this pull request due to being behind a feature flag and reducing QA testing load.
Changes in this PR impact the Autofill experience of the browser client
BIT has tested the core experience with these changes and all feature flags disabled.
â Fortunately, these BIT tests have passed! đ
Changes in this PR impact the Autofill experience of the browser client
BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.
â Fortunately, these BIT tests have passed! đ