[PM-36] - [Tech Debt] Move SearchService to libs/common/vault

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36

📔 Objective

This PR moves the search service to libs/common/vault which ensures vault code ownership.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – 5be1b936-f017-425e-8957-b2a789cf6328

Great job, no security vulnerabilities found in this Pull Request

[jaasen-livefront]

@djsmith85 @BTreston @mzieniukbw @nick-livefront Had to resolve a merge conflict so in GH's infinite wisdom all your reviews have been marked stale.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 36.86%. Comparing base (95841eb) to head (0a51221). Report is 36 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
libs/common/src/vault/services/search.service.ts	0.00%	3 Missing :warning:
libs/angular/src/services/jslib-services.module.ts	0.00%	2 Missing :warning:
...rowser/src/autofill/popup/fido2/fido2.component.ts	0.00%	1 Missing :warning:
apps/desktop/src/app/app.component.ts	0.00%	1 Missing :warning:
apps/desktop/src/app/tools/send/send.component.ts	0.00%	1 Missing :warning:
...op/src/vault/app/vault/vault-items-v2.component.ts	0.00%	1 Missing :warning:
...sktop/src/vault/app/vault/vault-items.component.ts	0.00%	1 Missing :warning:
...nsole/organizations/collections/vault.component.ts	0.00%	1 Missing :warning:
apps/web/src/app/app.component.ts	0.00%	1 Missing :warning:
apps/web/src/app/tools/send/send.component.ts	0.00%	1 Missing :warning:
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15251      +/-   ##
==========================================
- Coverage   36.90%   36.86%   -0.05%     
==========================================
  Files        3226     3228       +2     
  Lines       93225    93388     +163     
  Branches    14029    14056      +27     
==========================================
+ Hits        34404    34426      +22     
- Misses      57397    57536     +139     
- Partials     1424     1426       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.