clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-22741] - [Defect] Missing copy in the Edit policy Remove card item type policy

Open jaasen-livefront opened this issue 6 months ago • 3 comments

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22741

📔 Objective

This PR adds missing copy for the remove card item type policy.

📸 Screenshots

Screenshot 2025-06-17 at 2 37 10 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jaasen-livefront avatar Jun 17 '25 21:06 jaasen-livefront

Logo Checkmarx One – Scan Summary & Details1c6caf4e-314e-415e-9638-e52c9e1a2c1c

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Jun 17 '25 21:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.92%. Comparing base (05b34e9) to head (45fa020). Report is 51 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ations/policies/restricted-item-types.component.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15235   +/-   ##
=======================================
  Coverage   36.91%   36.92%           
=======================================
  Files        3225     3225           
  Lines       93125    93140   +15     
  Branches    13984    13985    +1     
=======================================
+ Hits        34381    34389    +8     
- Misses      57320    57327    +7     
  Partials     1424     1424           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 21:06 codecov[bot]