clients icon indicating copy to clipboard operation
clients copied to clipboard

wip

Open BTreston opened this issue 6 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar Jun 17 '25 20:06 BTreston

Logo Checkmarx One – Scan Summary & Details – 67eb8ab4-1d65-4eb5-b408-4b23056b9a49

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Jun 17 '25 20:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.88%. Comparing base (d8d3b1a) to head (72e7f67). Report is 2 commits behind head on ac/pm-12048-vNextCollectionService.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...collections/services/default-collection.service.ts 76.92% 2 Missing and 1 partial :warning:
...n-console/organizations/manage/groups.component.ts 0.00% 2 Missing :warning:
...console/organizations/members/members.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@                          Coverage Diff                           @@
##           ac/pm-12048-vNextCollectionService   #15233      +/-   ##
======================================================================
- Coverage                               36.90%   36.88%   -0.03%     
======================================================================
  Files                                    3217     3207      -10     
  Lines                                   92829    92544     -285     
  Branches                                13948    13889      -59     
======================================================================
- Hits                                    34261    34134     -127     
+ Misses                                  57139    57004     -135     
+ Partials                                 1429     1406      -23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 20:06 codecov[bot]