clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-20633] rename personal ownership

Open BTreston opened this issue 6 months ago • 3 comments

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20633

📔 Objective

Renames the Personal Ownership policy and associated variables to Organization Data Ownership. Updates comments to reflect the new verbiage and context that the change establishes.

📸 Screenshots

Screenshot 2025-06-17 at 3 37 26 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar Jun 17 '25 19:06 BTreston

Logo Checkmarx One – Scan Summary & Detailse43412ab-f9a1-4ed8-9081-8683e5c11233

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Jun 17 '25 20:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 34.78261% with 30 lines in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (674886a) to head (fcfcb43). Report is 52 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../policies/organization-data-ownership.component.ts 0.00% 9 Missing :warning:
...filter/components/organization-filter.component.ts 0.00% 5 Missing :warning:
...angular/src/vault/components/add-edit.component.ts 0.00% 2 Missing :warning:
.../vault-filter/components/vault-filter.component.ts 0.00% 2 Missing :warning:
...orm/services/default-cipher-form-config.service.ts 0.00% 2 Missing :warning:
...src/autofill/background/notification.background.ts 0.00% 1 Missing :warning:
.../src/services/encrypted-message-handler.service.ts 0.00% 1 Missing :warning:
...lt-filter/filters/organization-filter.component.ts 0.00% 1 Missing :warning:
.../app/admin-console/organizations/policies/index.ts 0.00% 1 Missing :warning:
...-console/organizations/policies/policies.module.ts 0.00% 1 Missing :warning:
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15228      +/-   ##
==========================================
- Coverage   36.91%   36.90%   -0.02%     
==========================================
  Files        3219     3225       +6     
  Lines       92972    93193     +221     
  Branches    13973    14016      +43     
==========================================
+ Hits        34322    34389      +67     
- Misses      57226    57380     +154     
  Partials     1424     1424              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 20:06 codecov[bot]