clients icon indicating copy to clipboard operation
clients copied to clipboard

encapsulate kludge property to fix invalid credential type error

Open audreyality opened this issue 7 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

N/A

📔 Objective

The user state subject injects a property into the objects it stores so that the state provider emits for every update. This property escaped containment, which caused reflection over the stored object to break. Deleting the property before outputting it should preserve the update behavior without breaking reflection.

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

audreyality avatar Jun 17 '25 19:06 audreyality

Logo Checkmarx One – Scan Summary & Details – c49527d3-e424-448e-8562-6d043d1e0076

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-6191 Npm-electron-36.3.1
detailsDescription: The package google chrome versions prior to 137.0.7151.119 is vulnerable Integer overflow in V8.
Attack Vector: NETWORK
Attack Complexity: LOW

ID: GX%2FrnqY1VT9ad4VyMwlWUaPbPZW%2F6y5iMvkFoQ9IiEc%3D
Vulnerable Package
HIGH CVE-2025-6192 Npm-electron-36.3.1
detailsDescription: The package google chrome versions prior to 137.0.7151.119 is vulnerable Use after free in Profiler.
Attack Vector: NETWORK
Attack Complexity: LOW

ID: Zn9dIKOodGUja0o9ZIkQVUv8gE2YGnQiRl27UDs0cUU%3D
Vulnerable Package

github-actions[bot] avatar Jun 17 '25 19:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@71bc684). Learn more about missing BASE report. Report is 25 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/common/src/tools/state/user-state-subject.ts 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15225   +/-   ##
=======================================
  Coverage        ?   36.92%           
=======================================
  Files           ?     3225           
  Lines           ?    93148           
  Branches        ?    13987           
=======================================
  Hits            ?    34394           
  Misses          ?    57332           
  Partials        ?     1422           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 18 '25 14:06 codecov[bot]