feat(policy-service): Policy Service Update [PM-22723] Add combineMasterPasswordPolicies method
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-22723
đ Objective
Add to the policy service api to allow for generating the master password policy options without a user id.
Note: the mergeMasterPasswordPolicyOptions will be more relevant in a later pr. I pulled this work out of https://github.com/bitwarden/clients/pull/14869 into this pr so it could unblock another developer.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â ee0dc4ef-5180-45f8-9d09-5e40b4388b5d
Great job, no security vulnerabilities found in this Pull Request
Codecov Report
Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
Project coverage is 36.90%. Comparing base (
92100d1) to head (a2d9f4f). Report is 30 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...-console/services/policy/default-policy.service.ts | 86.95% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #15216 +/- ##
=======================================
Coverage 36.90% 36.90%
=======================================
Files 3225 3225
Lines 93192 93189 -3
Branches 14016 14016
=======================================
+ Hits 34388 34393 +5
+ Misses 57380 57373 -7
+ Partials 1424 1423 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Converting to draft because I think these changes will be abandoned in favor of a master password policy service api. This was discussed with @eliykat and will see a separate pr shortly.
Closing because I brought the changes into the main pr to be reviewed with the other ac changes. See https://github.com/bitwarden/clients/pull/15319