clients icon indicating copy to clipboard operation
clients copied to clipboard

[WIP] OverlayBackground passes observable to generator callback

Open blackwood opened this issue 6 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

PM-18133

📔 Objective

[WIP]

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

blackwood avatar Jun 16 '25 14:06 blackwood

Logo Checkmarx One – Scan Summary & Details – 80678635-d3e5-44bd-a7a5-a38b9fd0222e

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Jun 16 '25 14:06 github-actions[bot]

Codecov Report

:x: Patch coverage is 55.31915% with 21 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 38.78%. Comparing base (801700d) to head (48ec703). :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/background/main.background.ts 13.33% 13 Missing :warning:
...c/services/default-credential-generator.service.ts 0.00% 4 Missing :warning:
...wser/src/autofill/background/overlay.background.ts 92.30% 2 Missing :warning:
apps/browser/src/background/commands.background.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15211   +/-   ##
=======================================
  Coverage   38.78%   38.78%           
=======================================
  Files        3411     3411           
  Lines       96922    96946   +24     
  Branches    14583    14584    +1     
=======================================
+ Hits        37593    37603   +10     
- Misses      57676    57690   +14     
  Partials     1653     1653           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 16 '25 15:06 codecov[bot]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

bw-ghapp[bot] avatar Oct 06 '25 15:10 bw-ghapp[bot]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

bw-ghapp[bot] avatar Oct 06 '25 15:10 bw-ghapp[bot]