clients icon indicating copy to clipboard operation
clients copied to clipboard

Refactor Fido2 Components

Open jholland-livefront opened this issue 6 months ago â€ĸ 4 comments

📔 Objective

Refactor the three passkey modals to clean up the code a little, fix typescript typing issues, and hopefully make these modals clearer for future changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jholland-livefront avatar Jun 06 '25 14:06 jholland-livefront

Logo Checkmarx One – Scan Summary & Details – 5fe63e5f-fc33-43e8-afb8-9003a3caed0f

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-6555 Npm-electron-34.0.0
detailsDescription: Use After Free in Animation in Google Chrome prior to 138.0.7204.49, allowed a remote attacker to potentially exploit heap corruption via a crafted...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: txYgariZ41KAR5rF1l1h2ogJNARCGNGKO0dvZMBICCw%3D
Vulnerable Package
MEDIUM CVE-2025-6556 Npm-electron-34.0.0
detailsRecommended version: 35.6.0
Description: Insufficient policy enforcement in Loader in Google Chrome prior to 138.0.7204.49 allowed a remote attacker to bypass content security policy via a...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: O2QUinhr3yKzBlhqTijE%2FoTd2EnsURGjM58CMoEtD%2FE%3D
Vulnerable Package
MEDIUM CVE-2025-6557 Npm-electron-34.0.0
detailsRecommended version: 35.6.0
Description: Insufficient data validation in DevTools in Google Chrome on Windows prior to 138.0.7204.49 allowed a remote attacker who convinced a user to engag...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: ytSjCHtBUhoOTZUpANi7QRLYVXPo66ii0nt%2FrkYTvTw%3D
Vulnerable Package

github-actions[bot] avatar Jun 06 '25 14:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 65.00000% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/passkey-provider@c873f5a). Learn more about missing BASE report.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tofill/modal/credentials/fido2-create.component.ts 65.95% 15 Missing and 1 partial :warning:
...utofill/modal/credentials/fido2-vault.component.ts 70.83% 7 Missing :warning:
...l/services/desktop-fido2-user-interface.service.ts 0.00% 5 Missing :warning:
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feature/passkey-provider   #15105   +/-   ##
===========================================================
  Coverage                            ?   36.89%           
===========================================================
  Files                               ?     3203           
  Lines                               ?    93074           
  Branches                            ?    13960           
===========================================================
  Hits                                ?    34335           
  Misses                              ?    57330           
  Partials                            ?     1409           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 06 '25 14:06 codecov[bot]

@coltonhurst I updated the PR to address your comments. I will ping @abergs to take a look too.

jholland-livefront avatar Jun 10 '25 18:06 jholland-livefront